Bug 74895

Summary: Make all calls to NamedNodeMap::setAttributes go through Element
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Added FIXME
none
Patch for landing none

Adam Klein
Reported 2011-12-19 15:38:29 PST
Make all calls to NamedNodeMap::setAttributes go through Element
Attachments
Patch (8.10 KB, patch)
2011-12-19 15:52 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Added FIXME (8.19 KB, patch)
2011-12-19 16:01 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.19 KB, patch)
2011-12-19 16:13 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-12-19 15:52:39 PST
Created attachment 119932 [details] Patch
Ryosuke Niwa
Comment 2 2011-12-19 15:55:31 PST
Comment on attachment 119932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119932&action=review > Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:66 > - newNode->attributes()->setAttributes(*nodeToReplace->attributes()); > + newNode->setAttributesFromElement(*nodeToReplace); I thought we're fixing this.
Adam Klein
Comment 3 2011-12-19 16:01:01 PST
Comment on attachment 119932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119932&action=review >> Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:66 >> + newNode->setAttributesFromElement(*nodeToReplace); > > I thought we're fixing this. See the second paragraph of my ChangeLog; I want to do that in a followup, making this change just a refactor. I've added a FIXME.
Adam Klein
Comment 4 2011-12-19 16:01:25 PST
Created attachment 119933 [details] Added FIXME
Ryosuke Niwa
Comment 5 2011-12-19 16:12:30 PST
Comment on attachment 119933 [details] Added FIXME View in context: https://bugs.webkit.org/attachment.cgi?id=119933&action=review > Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:66 > + // FIXME: Fix this to send the proper MutationRecords of MutationObservers are present. s/of/when/ ?
Adam Klein
Comment 6 2011-12-19 16:13:56 PST
Created attachment 119938 [details] Patch for landing
WebKit Review Bot
Comment 7 2011-12-19 23:49:32 PST
Comment on attachment 119938 [details] Patch for landing Clearing flags on attachment: 119938 Committed r103307: <http://trac.webkit.org/changeset/103307>
WebKit Review Bot
Comment 8 2011-12-19 23:49:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.