Bug 74857

Summary:

[Qt] [Gardening] Unskip a lot passing layout tests

Product:

WebKit

Reporter:

João Paulo Rechi Vita <jprvita>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ossy: review-, ossy: commit-queue-

João Paulo Rechi Vita

Reported 2011-12-19 05:47:09 PST

[Qt] [Gardening] Unskip a lot passing layout tests

Attachments
Patch (93.36 KB, patch) 2011-12-19 06:23 PST, João Paulo Rechi Vita	ossy: review- ossy: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

João Paulo Rechi Vita

Comment 1 2011-12-19 06:23:34 PST

Created attachment 119857 [details] Patch There are a lot of tests passing now that WEBKIT_TESTFONTS works with Qt 5.0.

Csaba Osztrogonác

Comment 2 2011-12-19 06:56:18 PST

Comment on attachment 119857 [details] Patch Thanks for the digging. But something is wrong with your environment, because more tests pass for me on Qt5-wk1. And we should check them on Qt5-WK2 too before unskipping.

João Paulo Rechi Vita

Comment 3 2011-12-19 08:48:27 PST

(In reply to comment #2) > (From update of attachment 119857 [details]) > Thanks for the digging. But something is wrong with your environment, because > more tests pass for me on Qt5-wk1. And we should check them on Qt5-WK2 too > before unskipping. Yes, for me too. This is the merge of the tests passing on WK1 and WK2. It has been tested on my Fedora 16 machine and on an Ubuntu 11.10 machine.

Csaba Osztrogonác

Comment 4 2011-12-19 08:50:49 PST

I unskipped many tests and added some of them to qt-wk2/Skipped: http://trac.webkit.org/changeset/103239 I'll land one more patch today. And then let's continue it tomorrow.

Note You need to log in before you can comment on or make changes to this bug.