Bug 74841

Summary:

Move WebAudio and WebSocket getters from JSDOMWindowCustom.cpp to JSDOMWindow{WebAudio,WebSocket}Custom.cpp

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore Misc.

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, japhet, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

74599

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2011-12-18 23:54:46 PST

This is the second step for bug 74599. We are planning to enable the [Supplemental] IDL and modularize WebAudio and WebSocket on AppleWebKit. In this bug, we move webkitAudioContext() and webSocket() from JSDOMWindowCustom.cpp to JSDOMWindowWebAudioCustom.cpp and JSDOMWindowWebSocketCustom.cpp, for modularization.

Attachments
Patch (19.71 KB, patch) 2011-12-19 00:52 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2011-12-19 00:52:53 PST

Created attachment 119835 [details] Patch

Adam Barth

Comment 2 2011-12-19 09:07:32 PST

Comment on attachment 119835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119835&action=review Ok. > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:598 > +// FIXME(haraken): This method will be removed, after all build systems support Usually WebKit skips the (haraken) part.

WebKit Review Bot

Comment 3 2011-12-19 15:27:05 PST

Comment on attachment 119835 [details] Patch Clearing flags on attachment: 119835 Committed r103274: <http://trac.webkit.org/changeset/103274>

WebKit Review Bot

Comment 4 2011-12-19 15:27:09 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.