Summary: | Interacting with GMail message lists is sluggish. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Tables | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2011-12-18 10:41:54 PST
Created attachment 119769 [details]
Patch
Created attachment 119771 [details]
Patch v2
Same patch + avoid computing the color property ID for before/after borders when we don't need it.
Comment on attachment 119771 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=119771&action=review > Source/WebCore/rendering/RenderTableCell.cpp:529 > + int beforeColorProperty = CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderBeforeColor, table->style()->direction(), table->style()->writingMode()); > + int afterColorProperty = CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderAfterColor, table->style()->direction(), table->style()->writingMode()); Do these still need to be resolved in the !computeColor case? > Source/WebCore/rendering/RenderTableCell.h:38 > +enum EComputeBorderColor { IgnoreBorderColor, ComputeBorderColor }; Please don’t use this obsolete naming convention. A better definition would be enum IncludeBorderColorOrNot { DoNotIncludeBorderColor, IncludeBorderColor }; Committed r103183: <http://trac.webkit.org/changeset/103183> |