Bug 74807

Summary: It should be possible to change the value of an Options variable without recompiling the world
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, wingo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch barraclough: review+

Filip Pizlo
Reported 2011-12-18 02:31:02 PST
Patch forthcoming.
Attachments
the patch (10.74 KB, patch)
2011-12-19 16:39 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-12-19 16:39:08 PST
Created attachment 119948 [details] the patch
Filip Pizlo
Comment 2 2011-12-19 17:07:18 PST
<rdar://problem/10604755>
Filip Pizlo
Comment 3 2011-12-19 17:12:25 PST
Landed in http://trac.webkit.org/changeset/103286
Andy Wingo
Comment 4 2011-12-21 14:36:56 PST
Hi Filip, Was this a simple reversion of bug 72938? Do you have any more specific feedback for me? Thanks, Andy
Filip Pizlo
Comment 5 2011-12-21 14:41:52 PST
(In reply to comment #4) > Hi Filip, > > Was this a simple reversion of bug 72938? Yes, it was. > > Do you have any more specific feedback for me? JavaScriptCore is not meant to be used on the command-line, but rather, as a framework. Often the only practical way to change a heuristic is to recompile. And if I have to do that, then I don't want to have to recompile the whole world. Hence why Options variables were originally defined in a C++ file as out-of-line constants. While I like your change, since it reduces code duplication, it means that to change an Options value I have to edit Options.h, which is included in a bunch of places, causing nearly a world-recompile. This is especially annoying when I'm debugging, profiling, and optimizing WebKit. -F
Note You need to log in before you can comment on or make changes to this bug.