Summary: | there should be a separate --lint-test-files step on the build bots | ||
---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, eric, levin, ojan, rniwa, tony |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 73603 |
Description
Dirk Pranke
2011-12-16 15:45:46 PST
(In reply to comment #0) > We can also probably tweak things so that we only ran this if something under LayoutTests/ changed in this build, if we had to. > > What do others think? Is this worth doing, or should we just try to beef up the presubmit checks if we're missing something? This is an excellent idea. Sounds great. Best of both worlds. This step currently exists on the chromium canaries (and deps bots). Since chromium is the only port actively using test expectations, and since most chromium devs watch the canaries more often than the build.webkit.org bots, and since it's not clear if other ports will start using test_expectations in anything like their current form any time soon ... I'm gonna call this closed. |