Bug 74761

Summary: [chromium] Remove WebCString's dependency on WebCore
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74583    
Attachments:
Description Flags
Patch
none
Patch fishd: review+

James Robinson
Reported 2011-12-16 15:23:30 PST
[chromium] Remove WebCString's dependency on WebCore
Attachments
Patch (2.67 KB, patch)
2011-12-16 15:24 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2011-12-16 15:33 PST, James Robinson 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-12-16 15:24:22 PST
Created attachment 119687 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2011-12-16 15:26:40 PST
Comment on attachment 119687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119687&action=review > Source/WebKit/chromium/src/WebCString.cpp:94 > + return String::fromUTF8(data(), length()); maybe slightly better as WebString::fromUTF8(...) ?
WebKit Review Bot
Comment 3 2011-12-16 15:27:41 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
James Robinson
Comment 4 2011-12-16 15:29:19 PST
Ah cool, I can avoid the <wtf/text/WTFString.h> #include as well that way.
James Robinson
Comment 5 2011-12-16 15:33:13 PST
Created attachment 119690 [details] Patch
James Robinson
Comment 6 2011-12-16 16:01:29 PST
Committed r103124: <http://trac.webkit.org/changeset/103124>
Note You need to log in before you can comment on or make changes to this bug.