Bug 74754

Summary: Rename EditCommandQt to UndoStepQt
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: cshu, hausmann, jkjiang, kenneth, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74490    
Bug Blocks:    
Attachments:
Description Flags
Patch rniwa: review+

Ryosuke Niwa
Reported 2011-12-16 14:50:31 PST
http://trac.webkit.org/changeset/103104 renamed the interface to unapply/reapply an editing action from EditCommand to UndoStep. We should rename EditCommandQt to match that.
Attachments
Patch (10.18 KB, patch)
2011-12-18 12:24 PST, Simon Hausmann 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2011-12-17 10:31:59 PST
Seems pretty related to what you were just working on Simon.
Antonio Gomes
Comment 2 2011-12-18 10:25:51 PST
We should do that on the BlackBerry port as well, Jacky :)
Simon Hausmann
Comment 3 2011-12-18 12:24:52 PST
Created attachment 119775 [details] Patch
Ryosuke Niwa
Comment 4 2011-12-18 12:27:55 PST
Comment on attachment 119775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119775&action=review > Source/WebKit/qt/WebCoreSupport/UndoStepQt.cpp:28 > + , m_cmd(cmd) Probably better to rename m_cmd and cmd to m_step and step.
Simon Hausmann
Comment 5 2011-12-18 13:51:14 PST
Landed with cmd -> step rename Committed r103188: <http://trac.webkit.org/changeset/103188>
Jacky Jiang
Comment 6 2011-12-18 16:22:46 PST
(In reply to comment #2) > We should do that on the BlackBerry port as well, Jacky :) Yes, will do it, thanks:)
Note You need to log in before you can comment on or make changes to this bug.