Bug 74740

Summary:

Remove unused ExceptionCode& argument from Element::setAttribute(QualifiedName)

Product:

WebKit

Reporter:

Adam Klein <adamk>

Component:

New Bugs

Assignee:

Adam Klein <adamk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, ojan, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Remove third arg	none
Patch for landing	none

Adam Klein

Reported 2011-12-16 12:31:58 PST

Replace Element::setAttribute convenience overload with a default value of ASSERT_NO_EXCEPTION

Attachments
Patch (2.41 KB, patch) 2011-12-16 12:33 PST, Adam Klein	no flags	Details Formatted Diff Diff
Remove third arg (10.27 KB, patch) 2011-12-19 16:15 PST, Adam Klein	no flags	Details Formatted Diff Diff
Patch for landing (14.10 KB, patch) 2011-12-19 17:12 PST, Adam Klein	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Klein

Comment 1 2011-12-16 12:33:21 PST

Created attachment 119651 [details] Patch

Ryosuke Niwa

Comment 2 2011-12-19 15:40:42 PST

Comment on attachment 119651 [details] Patch Did you verify that all callers of setAttribute(const QualifiedName& name, const AtomicString& value) can assert no exceptions? We used to ignore exceptions before this patch.

Adam Klein

Comment 3 2011-12-19 15:43:18 PST

(In reply to comment #2) > (From update of attachment 119651 [details]) > Did you verify that all callers of setAttribute(const QualifiedName& name, const AtomicString& value) can assert no exceptions? We used to ignore exceptions before this patch. It's impossible for setAttribute(const QualifiedName&, const AtomicString&, ExceptionCode&) to throw an exception: the implementation in Element.cpp doesn't name the ExceptionCode argument and thus cannot possibly modify it.

Ryosuke Niwa

Comment 4 2011-12-19 15:45:23 PST

(In reply to comment #3) > It's impossible for setAttribute(const QualifiedName&, const AtomicString&, ExceptionCode&) to throw an exception: the implementation in Element.cpp doesn't name the ExceptionCode argument and thus cannot possibly modify it. Then why don't we get rid of the version that takes ExceptionCode& ?

Adam Klein

Comment 5 2011-12-19 16:15:14 PST

Created attachment 119939 [details] Remove third arg

Adam Klein

Comment 6 2011-12-19 16:15:45 PST

(In reply to comment #4) > (In reply to comment #3) > > It's impossible for setAttribute(const QualifiedName&, const AtomicString&, ExceptionCode&) to throw an exception: the implementation in Element.cpp doesn't name the ExceptionCode argument and thus cannot possibly modify it. > > Then why don't we get rid of the version that takes ExceptionCode& ? Ha, good point, done!

Early Warning System Bot

Comment 7 2011-12-19 16:40:52 PST

Comment on attachment 119939 [details] Remove third arg Attachment 119939 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10936196

Adam Klein

Comment 8 2011-12-19 17:12:22 PST

Created attachment 119955 [details] Patch for landing

Adam Klein

Comment 9 2011-12-19 17:13:30 PST

Had to update a few callers in JSC SVG bindings, and one in Mac editing code.

WebKit Review Bot

Comment 10 2011-12-19 19:42:39 PST

Comment on attachment 119955 [details] Patch for landing Clearing flags on attachment: 119955 Committed r103296: <http://trac.webkit.org/changeset/103296>

WebKit Review Bot

Comment 11 2011-12-19 19:42:44 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.