Bug 74726

Summary:	REGRESSION(r103073): fast/forms/input-text-scroll-left-on-blur.html failing
Product:	WebKit	Reporter:	Adrienne Walker <enne>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	enne, mnaganov, rniwa
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Adrienne Walker 2011-12-16 10:00:41 PST

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fforms%2Finput-text-scroll-left-on-blur.html

Revision range is: http://trac.webkit.org/log/?verbose=on&rev=103073&stop_rev=103071

Comment 1 Adrienne Walker 2011-12-16 10:07:44 PST

Committed r103078: <http://trac.webkit.org/changeset/103078>

Comment 2 Adrienne Walker 2011-12-16 10:08:28 PST

Above commit was marking this as failing.  I didn't mean to close this bug.

Comment 3 Mikhail Naganov 2011-12-16 11:26:43 PST

I've rebaselined test expectations: http://trac.webkit.org/changeset/103081

Canaries seem to be happy.

Comment 4 Ryosuke Niwa 2011-12-16 12:03:29 PST

Was this test only failing on Chromium?

Comment 5 Ryosuke Niwa 2011-12-16 12:05:36 PST

Also why was linux not rebaselined?

Comment 6 Ryosuke Niwa 2011-12-16 12:10:32 PST

Tests are failing on Qt.

Comment 7 Ryosuke Niwa 2011-12-16 12:11:13 PST

Why did you just remove expectations for Qt without rebaselining the tests?

Comment 8 Mikhail Naganov 2011-12-16 12:24:19 PST

I've masked test results on all platforms initially. Then I've rebaselined Chromium tests. This test (input-text-scroll-left-on-blur.html) wasn't failing only on Chromium---I've updated expectations in WebKit Mac and Win as well.

Other ports seem to work differently---it looks like they just not upload results unless test is failing, no? I've already updated Gtk tests, will update Qt now.

Comment 9 Ryosuke Niwa 2011-12-16 12:25:37 PST

(In reply to comment #8)
> I've masked test results on all platforms initially. Then I've rebaselined Chromium tests. This test (input-text-scroll-left-on-blur.html) wasn't failing only on Chromium---I've updated expectations in WebKit Mac and Win as well.
> 
> Other ports seem to work differently---it looks like they just not upload results unless test is failing, no? I've already updated Gtk tests, will update Qt now.

I don't think webkit-patch rebaseline-expectations work for non-Chromium ports if you used that. Neither does garden-o-matic.

Comment 10 Mikhail Naganov 2011-12-16 12:28:55 PST

I understand that. What I mean is that if you look at "upload results" log on Gtk or Qt, they only upload results of failed tests, not for all tests:

http://build.webkit.org/builders/Qt%20Linux%20Release/builds/41118/steps/MasterShellCommand/logs/stdio

Comment 11 Adrienne Walker 2011-12-16 12:33:58 PST

(In reply to comment #3)
> I've rebaselined test expectations: http://trac.webkit.org/changeset/103081
> 
> Canaries seem to be happy.

Mac 10.5 (CG) canary seems to be sad:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1787

Comment 12 Adrienne Walker 2011-12-16 15:59:17 PST

Committed r103123: <http://trac.webkit.org/changeset/103123>

Comment 13 Mikhail Naganov 2011-12-19 03:48:02 PST

Tests were passing on Mac bots, after I've uploaded expectation files:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1832/steps/webkit_tests/logs/stdio
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28CG%29%28dbg%29/builds/2097/steps/webkit_tests/logs/stdio

Suppressions removed in http://trac.webkit.org/changeset/103226