Bug 74725

Summary:

Implement block-scoped const

Product:

WebKit

Reporter:

Andy Wingo <wingo>

Component:

JavaScriptCore

Assignee:

Andy Wingo <wingo>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

barraclough, emanuele.aina, eric, fpizlo, ggaren, m.goleb+bugzilla, oliver, saam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

74509, 74718

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	fpizlo: review-

Andy Wingo

Reported 2011-12-16 09:42:41 PST

This is related to bug 31813, but isn't quite yet baked, as it doesn't do the temporal dead zone dance. Also it is lacking a test suite, and relies on the flags and options from bug 74510. But still, it's probably good to get early feedback on this approach. Also I was getting a bit paranoid, having this patch only on my hard drive and not in the cloud-tubes :)

Attachments
Patch (25.64 KB, patch) 2011-12-16 09:46 PST, Andy Wingo	no flags	Details Formatted Diff Diff
Patch (25.08 KB, patch) 2012-01-18 10:39 PST, Andy Wingo	fpizlo: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andy Wingo

Comment 1 2011-12-16 09:46:13 PST

Created attachment 119625 [details] Patch

Eric Seidel (no email)

Comment 2 2011-12-21 12:25:50 PST

I would strongly encourage you to engage with the various JSC folks on #webkit in order to get your set of JSC patches reviewed as quickly as possible. :)

Gavin Barraclough

Comment 3 2011-12-21 12:39:06 PST

(In reply to comment #2) > I would strongly encourage you to engage with the various JSC folks on #webkit in order to get your set of JSC patches reviewed as quickly as possible. :) OOI discussion of the implementation is taking place on these bugs - recent feedback on the design has been provided on Bug#74718. But yes - #webkit is the place to be. :o)

Eric Seidel (no email)

Comment 4 2011-12-21 12:45:29 PST

(In reply to comment #3) > (In reply to comment #2) > > I would strongly encourage you to engage with the various JSC folks on #webkit in order to get your set of JSC patches reviewed as quickly as possible. :) > > OOI discussion of the implementation is taking place on these bugs - recent feedback on the design has been provided on Bug#74718. But yes - #webkit is the place to be. :o) Great! The first couple bugs of wingo's I ran into had no CC's. Seeing further bugs I see he's engaged you all in this process. Thank you!

Andy Wingo

Comment 5 2012-01-18 10:39:01 PST

Created attachment 122962 [details] Patch

Filip Pizlo

Comment 6 2013-10-31 11:34:48 PDT

Comment on attachment 122962 [details] Patch This looks abandoned and in need of a massive rebase.

Emanuele Aina

Comment 7 2015-11-30 07:00:40 PST

Now that bug 31813 has been closed, is this bug (and bug 74509) still useful?

Saam Barati

Comment 8 2015-11-30 10:59:25 PST

(In reply to comment #7) > Now that bug 31813 has been closed, is this bug (and bug 74509) still useful? Nope. This is already implemented.

Saam Barati

Comment 9 2015-11-30 11:00:28 PST

*** This bug has been marked as a duplicate of bug 31813 ***

Note You need to log in before you can comment on or make changes to this bug.