Bug 74722

Summary: [chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame.
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, fischman, fishd, jamesr, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dana Jansens
Reported 2011-12-16 09:08:13 PST
[chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame.
Attachments
Patch (5.29 KB, patch)
2011-12-16 09:10 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2011-12-16 09:10:53 PST
Created attachment 119616 [details] Patch @fischman is changing the video compositing process so that the current frame is grabbed from the impl thread instead of the main thread. This conflicts with our setting the LC::opaque flag when retrieving a video frame. Instead, this adds a setOpaque() function to the WebMediaPlayerClient interface, that forwards the flag through to the VideoLayerChromium. The flag will be set from chromium's WebMediaPlayerImpl when it initializes its pipeline.
WebKit Review Bot
Comment 2 2011-12-16 09:13:09 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
WebKit Review Bot
Comment 3 2011-12-16 11:24:43 PST
Comment on attachment 119616 [details] Patch Clearing flags on attachment: 119616 Committed r103086: <http://trac.webkit.org/changeset/103086>
WebKit Review Bot
Comment 4 2011-12-16 11:24:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.