Bug 74698

Summary: Remove top-level code completely from prepare-ChangeLog
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Tools / TestsAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73531    
Attachments:
Description Flags
Patch
darin: review+
patch for commit none

Kentaro Hara
Reported 2011-12-16 01:56:25 PST
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. In this bug we move top-level code into a subroutine and remove all top-level code.
Attachments
Patch (11.13 KB, patch)
2011-12-16 05:46 PST, Kentaro Hara 		darin: review+
DetailsFormatted DiffDiff
patch for commit (11.12 KB, patch)
2011-12-17 07:53 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-16 05:46:10 PST
Created attachment 119605 [details] Patch
Darin Adler
Comment 2 2011-12-16 10:36:09 PST
Comment on attachment 119605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119605&action=review > Tools/Scripts/prepare-ChangeLog:-108 > - > -### Constant variables. What’s the rationale for removing this comment? Is it just a bad comment?
Kentaro Hara
Comment 3 2011-12-17 07:53:55 PST
Created attachment 119724 [details] patch for commit
Kentaro Hara
Comment 4 2011-12-17 07:54:45 PST
(In reply to comment #2) > (From update of attachment 119605 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119605&action=review > > > Tools/Scripts/prepare-ChangeLog:-108 > > - > > -### Constant variables. > > What’s the rationale for removing this comment? Is it just a bad comment? Recovered this comment and committed. Thanks.
WebKit Review Bot
Comment 5 2011-12-17 10:16:04 PST
Comment on attachment 119724 [details] patch for commit Clearing flags on attachment: 119724 Committed r103149: <http://trac.webkit.org/changeset/103149>
Note You need to log in before you can comment on or make changes to this bug.