Bug 74676

Summary: Placement new does an unnecessary NULL check
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, levin+threading, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch
none
Patch sam: review+

Geoffrey Garen
Reported 2011-12-15 19:42:10 PST
Placement new does an unnecessary NULL check
Attachments
Patch (113.02 KB, patch)
2011-12-15 21:17 PST, Geoffrey Garen 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (113.31 KB, patch)
2011-12-15 21:53 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (117.85 KB, patch)
2011-12-15 23:14 PST, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-12-15 21:17:30 PST
Created attachment 119558 [details] Patch
Gyuyoung Kim
Comment 2 2011-12-15 21:40:24 PST
Comment on attachment 119558 [details] Patch Attachment 119558 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10914532
WebKit Review Bot
Comment 3 2011-12-15 21:53:40 PST
Comment on attachment 119558 [details] Patch Attachment 119558 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10903538
Geoffrey Garen
Comment 4 2011-12-15 21:53:40 PST
Created attachment 119563 [details] Patch
Geoffrey Garen
Comment 5 2011-12-15 23:14:07 PST
Created attachment 119572 [details] Patch
Mark Hahnenberg
Comment 6 2011-12-16 15:29:27 PST
Comment on attachment 119572 [details] Patch LGTM, but I'm not a reviewer yet :-) Just learning the reviewing ropes, so to speak.
Geoffrey Garen
Comment 7 2011-12-19 09:45:24 PST
Committed r103243: <http://trac.webkit.org/changeset/103243>
Csaba Osztrogonác
Comment 8 2011-12-19 14:56:48 PST
(In reply to comment #7) > Committed r103243: <http://trac.webkit.org/changeset/103243> It broke Qt Win build: In file included from /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecificWin.cpp:23:0: /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecific.h: In member function 'WTF::ThreadSpecific<T>::operator T*()': /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecific.h:256:14: error: 'NotNull' was not declared in this scope
Geoffrey Garen
Comment 9 2011-12-19 17:23:15 PST
Qt build fix: <http://trac.webkit.org/changeset/103287>
Note You need to log in before you can comment on or make changes to this bug.