| Summary: | Placement new does an unnecessary NULL check | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, japhet, levin+threading, ossy, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Geoffrey Garen
2011-12-15 19:42:10 PST
Created attachment 119558 [details]
Patch
Comment on attachment 119558 [details] Patch Attachment 119558 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10914532 Comment on attachment 119558 [details] Patch Attachment 119558 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10903538 Created attachment 119563 [details]
Patch
Created attachment 119572 [details]
Patch
Comment on attachment 119572 [details]
Patch
LGTM, but I'm not a reviewer yet :-) Just learning the reviewing ropes, so to speak.
Committed r103243: <http://trac.webkit.org/changeset/103243> (In reply to comment #7) > Committed r103243: <http://trac.webkit.org/changeset/103243> It broke Qt Win build: In file included from /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecificWin.cpp:23:0: /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecific.h: In member function 'WTF::ThreadSpecific<T>::operator T*()': /ramdisk/qt-windows-32bit-release/build/Source/JavaScriptCore/wtf/ThreadSpecific.h:256:14: error: 'NotNull' was not declared in this scope Qt build fix: <http://trac.webkit.org/changeset/103287> |