Bug 74645

Summary: m_hasCounterNodeMap and m_everHadLayout should be private to RenderObject
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, darin, eric, hyatt, koivisto, mitz, ojan, paroga, simon.fraser, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74646    
Attachments:
Description Flags
cleanup eric: review+

Ryosuke Niwa
Reported 2011-12-15 13:15:10 PST
No brainer. Public member variable is bad.
Attachments
cleanup (11.62 KB, patch)
2011-12-15 13:18 PST, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-12-15 13:18:31 PST
Created attachment 119490 [details] cleanup
Eric Seidel (no email)
Comment 2 2011-12-15 13:22:23 PST
Comment on attachment 119490 [details] cleanup OK.
Ryosuke Niwa
Comment 3 2011-12-15 13:30:26 PST
Committed r102979: <http://trac.webkit.org/changeset/102979>
Patrick R. Gansterer
Comment 4 2011-12-16 04:23:26 PST
r102979 <http://trac.webkit.org/changeset/102979> broke WinCE build. I've commited r103056 <http://trac.webkit.org/changeset/103056> to fix it, but I'm not 100% sure if my fix is ok. The MSVC2005 compiler for WinCE implements an old behaviour (maybe compiler bug), where the nested classes don't have full access to the enclosing class.
Ryosuke Niwa
Comment 5 2011-12-16 07:27:05 PST
(In reply to comment #4) > r102979 <http://trac.webkit.org/changeset/102979> broke WinCE build. > I've commited r103056 <http://trac.webkit.org/changeset/103056> to fix it, but I'm not 100% sure if my fix is ok. > The MSVC2005 compiler for WinCE implements an old behaviour (maybe compiler bug), where the nested classes don't have full access to the enclosing class. Thanks for the fix but the fix doesn't make much sense. What's nested class to do with everHadLayout being protected? Nothing in RenderObjectBitfields should be accessing anything in RenderObject.
Patrick R. Gansterer
Comment 6 2011-12-16 07:35:54 PST
(In reply to comment #5) > (In reply to comment #4) > > r102979 <http://trac.webkit.org/changeset/102979> broke WinCE build. > > I've commited r103056 <http://trac.webkit.org/changeset/103056> to fix it, but I'm not 100% sure if my fix is ok. > > The MSVC2005 compiler for WinCE implements an old behaviour (maybe compiler bug), where the nested classes don't have full access to the enclosing class. > > Thanks for the fix but the fix doesn't make much sense. What's nested class to do with everHadLayout being protected? Nothing in RenderObjectBitfields should be accessing anything in RenderObject. The problem is/was that RenderBlock::FloatWithRect wants to access everHadLayout() at http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlock.h?rev=103030#L483, but the WinCE compiler doesn't allow it since the nested class doesn't get the required rights to access protected members.
Note You need to log in before you can comment on or make changes to this bug.