Bug 74643

Summary: [BlackBerry] Upstream BlackBerry WebCoreSupport drag client and context menu client
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, manyoso, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch none

Description Jacky Jiang 2011-12-15 12:54:18 PST
Upstream BlackBerry WebCoreSupport drag client and context menu client.
Comment 1 Jacky Jiang 2011-12-15 13:04:47 PST
Created attachment 119488 [details]
Patch
Comment 2 Rob Buis 2011-12-15 13:23:12 PST
Comment on attachment 119488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119488&action=review

Needs a bit of cleanup.

> Source/WebKit/blackberry/WebCoreSupport/DragClientBlackBerry.h:33
> +    virtual void startDrag(void*, const IntPoint&, const IntPoint&, Clipboard*, Frame*, bool);

I'd like to see more names here. Especially bool is not obvious to me.

> Source/WebKit/blackberry/WebCoreSupport/DragClientBlackBerry.h:34
> +    virtual void* createDragImageForLink(KURL&, const String&, Frame*);

I'd like to see more names here.
Comment 3 Jacky Jiang 2011-12-15 14:03:00 PST
Created attachment 119499 [details]
Patch

Update the patch according to Rob's comments and remove useless function DragClientBlackBerry::createDragImageForLink().
Comment 4 Jacky Jiang 2011-12-15 14:05:15 PST
Comment on attachment 119488 [details]
Patch

Discard the old one.
Comment 5 Rob Buis 2011-12-15 14:12:48 PST
Comment on attachment 119499 [details]
Patch

Looks great.
Comment 6 WebKit Review Bot 2011-12-15 21:23:03 PST
Comment on attachment 119499 [details]
Patch

Clearing flags on attachment: 119499

Committed r103022: <http://trac.webkit.org/changeset/103022>
Comment 7 WebKit Review Bot 2011-12-15 21:23:08 PST
All reviewed patches have been landed.  Closing bug.