Bug 74638

Summary: Make Element::setAttributeInternal inline in an attempt to avoid function call overhead
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Klein
Reported 2011-12-15 12:07:22 PST
Make Element::setAttributeInternal inline in an attempt to avoid function call overhead
Attachments
Patch (1.75 KB, patch)
2011-12-15 12:11 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-12-15 12:11:33 PST
Created attachment 119479 [details] Patch
Adam Klein
Comment 2 2011-12-15 12:13:38 PST
See also the Chromium perf bots: http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcore/report.html?history=500&rev=-1&graph=dom_attr_element_property___value Looking at the right half, the big drop was flipping ENABLE(MUTATION_OBSERVERS) to true. The uplift was Rafael's http://trac.webkit.org/changeset/102721. But in the meantime, I'd submitted http://trac.webkit.org/changeset/102695, which I suspect further regressed performance of the set-attribute-through-property case.
WebKit Review Bot
Comment 3 2011-12-15 20:19:50 PST
Comment on attachment 119479 [details] Patch Clearing flags on attachment: 119479 Committed r103017: <http://trac.webkit.org/changeset/103017>
WebKit Review Bot
Comment 4 2011-12-15 20:19:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.