Bug 74615

Summary: [WK2] Extend WebNotification to include its origin
Product: WebKit Reporter: Jon Lee <jonlee>
Component: New BugsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch abarth: review-

Jon Lee
Reported 2011-12-15 09:24:04 PST
The origin could be used to help distinguish the source of shown notifications. <rdar://problem/10587164>
Attachments
Patch (12.53 KB, patch)
2011-12-15 09:46 PST, Jon Lee 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2011-12-15 09:46:24 PST
Created attachment 119442 [details] Patch
Jon Lee
Comment 2 2011-12-15 10:45:08 PST
Committed http://trac.webkit.org/changeset/102960
Adam Barth
Comment 3 2011-12-19 11:16:21 PST
Comment on attachment 119442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119442&action=review > Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp:76 > - m_process->connection()->send(Messages::WebNotificationManagerProxy::Show(notification->contents().title, notification->contents().body, notificationID), page->pageID()); > + m_process->connection()->send(Messages::WebNotificationManagerProxy::Show(notification->contents().title, notification->contents().body, notification->scriptExecutionContext()->securityOrigin()->databaseIdentifier(), notificationID), page->pageID()); Notifications should not be using the database identify. The database identify is only for use by databases. Instead, you should use SecurityOrigin::toString and SecurityOrigin::createFromString.
Adam Barth
Comment 4 2011-12-19 11:16:42 PST
identify => identifier
Jon Lee
Comment 5 2011-12-20 14:28:11 PST
Since this patch was already committed, tracking Adam's comment as bug 74956.
Eric Seidel (no email)
Comment 6 2011-12-20 14:35:02 PST
Silly sam! :p
Note You need to log in before you can comment on or make changes to this bug.