Bug 74608

Summary: [Qt] Test results launched with minibrowser in touch mode
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED LATER    
Severity: Normal CC: abarth, kenneth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2011-12-15 08:03:11 PST
When running the webkit-test using webkittestrunner using 'run-webkit-tests --qt -2' the results are after the test run shown in the MiniBrowser using the simulated touch interface. This is probably a result of changing the default of the minibrowser from desktop-style to touch-style. I have not added a changelog
Attachments
Patch (1.11 KB, patch)
2011-12-15 08:04 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2011-12-15 08:04:56 PST
Created attachment 119427 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-12-15 08:26:32 PST
Comment on attachment 119427 [details] Patch Im ok with that, but what is the reasoning? Was something not working? We intend the non-desktop version to become the default
Allan Sandfeld Jensen
Comment 3 2011-12-19 01:19:15 PST
Currently the touch interface works very poorly with keyboard and mouse. As long as the touch interface is hard to use from a desktop, we should prefer the desktop interface when the minibrowser is launched for actual work and not just for testing. Also the desktop-interface is already used with webkit tests are run with dumprendertree (webkit1) runner, it is only when webkit tests are run with webkittestrunner (webkit2) that touch interface is launched.
Kenneth Rohde Christiansen
Comment 4 2011-12-19 01:23:33 PST
Why is it not up for review? Anyway, we need to make the touch interface a first citizen even on desktop.
WebKit Review Bot
Comment 5 2011-12-19 02:31:41 PST
Attachment 119427 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Rohde Christiansen
Comment 6 2011-12-19 02:32:25 PST
Comment on attachment 119427 [details] Patch cq- due to lack of bug number in changelog
Eric Seidel (no email)
Comment 7 2011-12-21 14:59:38 PST
Comment on attachment 119427 [details] Patch Allan is not a committer, so might as well set r-. :)
Allan Sandfeld Jensen
Comment 8 2012-05-21 08:24:55 PDT
Without context-menus there are no benefits at all in using desktop mode, and maybe later there never will be. Closing this bug for now.
Note You need to log in before you can comment on or make changes to this bug.