Bug 74570

Summary: Web Inspector: #hex colors are not highlighted in CSS files
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.webkit.org/css/blue.css
Attachments:
Description Flags
Patch pfeldman: review+

Timothy Hatcher
Reported 2011-12-14 17:32:57 PST
A hex color is not highlighted in CSS. If the color is all numerical the numbers will be highlighted, but not the #. And if there is [a-fA-F] there is no highlight. The whole thing should be highlighted, including the # and get css-color token type. The syntax highlight CSS file already expects that token type, but it isn't produced by the tokenizer. See http://www.webkit.org/css/blue.css
Attachments
Patch (89.16 KB, patch)
2011-12-15 08:30 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-12-15 08:30:15 PST
Created attachment 119432 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2011-12-15 08:46:34 PST
Committed r102943: <http://trac.webkit.org/changeset/102943>
Note You need to log in before you can comment on or make changes to this bug.