Bug 74564 – Mac WebScriptDebugger crashes beneath sourceParsed()

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Michael Saboff]

The code in Source/WebKit/Mac/WebView/WebScriptDebugger.mm at line 65 is crashing due to the cast of a StringImpl* to a unichar*.

61  static NSString *toNSString(SourceProvider* s)
62  {
63      if (!s->length())
64          return nil;
65      return [NSString stringWithCharacters:reinterpret_cast<const unichar*>(s->data()) length:s->length()];
66  }

The code needs to be changed to 
    return [NSString stringWithCharacters:reinterpret_cast<const unichar*>(s->data()->characters()) length:s->length()];

To actually access the characters.

In radar as <rdar://problem/10521033>.

[Michael Saboff]

Created attachment 119337 [details]
Patch

[Gavin Barraclough]

Comment on attachment 119337 [details]
Patch

please give static_cast a go, r+ either way.

[Darin Adler]

Comment on attachment 119337 [details]
Patch

Might also want to try without a cast at all.

[Michael Saboff]

Committed r102856: <http://trac.webkit.org/changeset/102856>