Summary: | [Qt] DeviceOrientationClientQt should initialize m_controller to zero. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Færøy <ahf> | ||||||||
Component: | WebKit Qt | Assignee: | Alexander Færøy <ahf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | kenneth, tonikitoo, vestbo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexander Færøy
2011-12-14 11:00:52 PST
Created attachment 119253 [details]
Patch
Comment on attachment 119253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119253&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:33 > + m_controller = 0; initializer Created attachment 119257 [details]
Patch
Adding Tor Arne. Comment on attachment 119257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:43 > + ASSERT(controller); > m_controller = controller; > + m_provider->setController(controller); you seem to be doing more than what to changelog'ed. > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:32 > + : m_lastOrientation(DeviceOrientation::create()) > + , m_controller(0) > + , m_sensor() ditto (In reply to comment #5) > (From update of attachment 119257 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > > > Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:43 > > + ASSERT(controller); > > m_controller = controller; > > + m_provider->setController(controller); > > you seem to be doing more than what to changelog'ed. s/what to/what you/g Comment on attachment 119257 [details]
Patch
Write proper changelogs Alex! :-)
(In reply to comment #7) > (From update of attachment 119257 [details]) > Write proper changelogs Alex! :-) It is because you are not around to pet me! Jokes aside, new patch coming up in one moment. It is being split up such that the setController() changes are being moved to a separate patch. Comment on attachment 119257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:31 > + , m_controller(0) why isn't it a smart controller? you seem to use it by two here in this patch? should it be reffed? (In reply to comment #9) > (From update of attachment 119257 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > > > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:31 > > + , m_controller(0) > > why isn't it a smart controller? you seem to use it by two here in this patch? should it be reffed? smart pointer :-) Created attachment 119278 [details]
Patch
Comment on attachment 119278 [details] Patch Clearing flags on attachment: 119278 Committed r102822: <http://trac.webkit.org/changeset/102822> All reviewed patches have been landed. Closing bug. |