Bug 74521

Summary:

Web Inspector: Console should show network messages origins.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, yurys

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+
Screenshot	none

Vsevolod Vlasov

Reported 2011-12-14 10:56:14 PST

We show stack trace only for network messages now. Top call frame is not always pointing to the same location as origin (network requested could have been initiated from parser, so we can use resource.initiator as an origin).

Attachments
Patch (8.85 KB, patch) 2011-12-14 12:03 PST, Vsevolod Vlasov	pfeldman: review+	Details Formatted Diff Diff
Screenshot (95.89 KB, image/png) 2011-12-15 04:13 PST, Vsevolod Vlasov	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2011-12-14 12:03:17 PST

Created attachment 119272 [details] Patch

Pavel Feldman

Comment 2 2011-12-14 15:36:12 PST

Comment on attachment 119272 [details] Patch Is there a UI mock / screenshot for this?

Vsevolod Vlasov

Comment 3 2011-12-15 04:13:42 PST

Created attachment 119411 [details] Screenshot See links on the right side of console.

Vsevolod Vlasov

Comment 4 2011-12-15 04:16:21 PST

Committed r102919: <http://trac.webkit.org/changeset/102919>

Csaba Osztrogonác

Comment 5 2011-12-15 08:13:21 PST

Reopen, because it broke these tests on the Qt bot: - http://build.webkit.org/results/Qt%20Linux%20Release/r102924%20(41046)/http/tests/inspector/console-resource-errors-pretty-diff.html - http://build.webkit.org/results/Qt%20Linux%20Release/r102924%20(41046)/http/tests/inspector/console-xhr-logging-pretty-diff.html Could you check it, please?

Csaba Osztrogonác

Comment 6 2011-12-15 08:23:24 PST

(In reply to comment #5) > Reopen, because it broke these tests on the Qt bot: > - http://build.webkit.org/results/Qt%20Linux%20Release/r102924%20(41046)/http/tests/inspector/console-resource-errors-pretty-diff.html > - http://build.webkit.org/results/Qt%20Linux%20Release/r102924%20(41046)/http/tests/inspector/console-xhr-logging-pretty-diff.html > > Could you check it, please? I skipped them on Qt to paint the bot green: http://trac.webkit.org/changeset/102938 Please unskip them if you land a fix. Thanks.

Vsevolod Vlasov

Comment 7 2011-12-15 08:41:11 PST

Fixed: Committed r102940: <http://trac.webkit.org/changeset/102940>

Note You need to log in before you can comment on or make changes to this bug.