Bug 74493

Summary: [GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, mrobinson, samuel_white, zan
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98347    
Attachments:
Description Flags
Patch none

Description Philippe Normand 2011-12-14 01:59:32 PST
Happens at least on the 64-bit Release bot. Diff:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/unknown-roles-not-exposed-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/unknown-roles-not-exposed-actual.txt 
@@ -9,7 +9,7 @@
 TEST COMPLETE
 PASS root.role is 'AXRole: scroll pane'
 PASS webArea.role is 'AXRole: document frame'
-PASS iframe.role is 'AXRole: scroll pane'
-PASS iframe_body.role is 'AXRole: document frame'
-PASS iframe_button.role is 'AXRole: push button'
+FAIL iframe.role should be AXRole: scroll pane. Was AXRole: panel.
+FAIL iframe_body.role should be AXRole: document frame. Was AXRole: scroll pane.
+FAIL iframe_button.role should be AXRole: push button. Was AXRole: document frame.

Will update test_expectations accordingly.
Comment 1 Mario Sanchez Prada 2012-01-10 06:49:49 PST
(In reply to comment #0)
> Happens at least on the 64-bit Release bot. Diff:
> 
> --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/unknown-roles-not-exposed-expected.txt 
> +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/accessibility/unknown-roles-not-exposed-actual.txt 
> @@ -9,7 +9,7 @@
>  TEST COMPLETE
>  PASS root.role is 'AXRole: scroll pane'
>  PASS webArea.role is 'AXRole: document frame'
> -PASS iframe.role is 'AXRole: scroll pane'
> -PASS iframe_body.role is 'AXRole: document frame'
> -PASS iframe_button.role is 'AXRole: push button'
> +FAIL iframe.role should be AXRole: scroll pane. Was AXRole: panel.
> +FAIL iframe_body.role should be AXRole: document frame. Was AXRole: scroll pane.
> +FAIL iframe_button.role should be AXRole: push button. Was AXRole: document frame.
> 
> Will update test_expectations accordingly.

This is strange... I can't reproduce it in my laptop (64 bit release) nor in the 64bit debug bot. Perhaps it got fixed along the way?

If that's the case, perhaps unskipping and see how it behaves could be interesting
Comment 2 Martin Robinson 2012-01-10 08:12:20 PST
Sure, no harm in trying to unskip.
Comment 3 Mario Sanchez Prada 2012-01-10 09:41:31 PST
Committed r104590: <http://trac.webkit.org/changeset/104590>
Comment 4 Mario Sanchez Prada 2012-01-10 09:42:23 PST
(In reply to comment #3)
> Committed r104590: <http://trac.webkit.org/changeset/104590>

Unskipped again. Let's keep and eye on this to reopen this bug if we see the failure happening again in the bots
Comment 5 Mario Sanchez Prada 2012-01-12 06:09:34 PST
Reopening, as it has been randomly failing again in the bots. Added again to test_expectations.txt:
http://trac.webkit.org/changeset/104819
Comment 6 Joanmarie Diggs 2015-05-05 12:42:42 PDT
Created attachment 252398 [details]
Patch
Comment 7 Joanmarie Diggs 2015-05-05 12:44:59 PDT
The attached patch should make this test more reliable and cross-platform friendly. Chris, are you aware of any platform where exposing an object with an unknown role is actually the right thing to do?
Comment 8 WebKit Commit Bot 2015-05-05 16:46:01 PDT
Comment on attachment 252398 [details]
Patch

Clearing flags on attachment: 252398

Committed r183842: <http://trac.webkit.org/changeset/183842>
Comment 9 WebKit Commit Bot 2015-05-05 16:46:06 PDT
All reviewed patches have been landed.  Closing bug.