Bug 74464

Summary: Share blend progress code
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, dino, gustavo, macpherson, morrita, rniwa, simon.fraser, thorton, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dino: review+, webkit.review.bot: commit-queue-

Description Simon Fraser (smfr) 2011-12-13 16:57:52 PST
Share blend progress code
Comment 1 Simon Fraser (smfr) 2011-12-13 17:01:45 PST
Created attachment 119110 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-12-13 17:11:14 PST
Comment on attachment 119110 [details]
Patch

Attachment 119110 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10876032
Comment 3 Simon Fraser (smfr) 2011-12-13 17:16:03 PST
Created attachment 119116 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-13 18:34:13 PST
Comment on attachment 119116 [details]
Patch

Attachment 119116 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10875046

New failing tests:
fast/gradients/css3-radial-gradients.html
fast/gradients/css3-repeating-radial-gradients.html
Comment 5 Gyuyoung Kim 2011-12-13 18:48:40 PST
Comment on attachment 119116 [details]
Patch

Attachment 119116 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10871059
Comment 6 Dean Jackson 2011-12-13 20:19:19 PST
Comment on attachment 119116 [details]
Patch

Looks good other than the failures. I can't see where radial gradient is failing.

GLSL uses the term "mix" where we use "blend" - I don't suppose it is worth the effort to change, and blend makes more sense.
Comment 7 Simon Fraser (smfr) 2011-12-13 21:38:14 PST
(In reply to comment #4)
> (From update of attachment 119116 [details])
> Attachment 119116 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10875046
> 
> New failing tests:
> fast/gradients/css3-radial-gradients.html
> fast/gradients/css3-repeating-radial-gradients.html

Why don't these test failures show up in the output: http://queues.webkit.org/results/10875046 ?
Comment 8 Simon Fraser (smfr) 2011-12-13 21:54:42 PST
http://trac.webkit.org/changeset/102740
Comment 10 Dean Jackson 2011-12-14 08:32:27 PST
(In reply to comment #9)
> This patch broke Windows builds:
> http://build.webkit.org/builders/Chromium%20Win%20Release/builds/36788/steps/compile-webkit/logs/stdio
> http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/24728/steps/compile-webkit/logs/stdio
> 
> lround isn't available on Visual Studio although it's part of ANSI C.

Weird. lround was already being used - this patch just moved it.
Comment 11 Dean Jackson 2011-12-14 08:42:41 PST
Seems that the build error was fixed by
http://trac.webkit.org/changeset/102745
Comment 12 Simon Fraser (smfr) 2011-12-14 08:44:30 PST
Ah, I was just about to make the same change. Thanks morrita!