Summary: | Share blend progress code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, dglazkov, dino, gustavo, macpherson, morrita, rniwa, simon.fraser, thorton, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-12-13 16:57:52 PST
Created attachment 119110 [details]
Patch
Comment on attachment 119110 [details] Patch Attachment 119110 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10876032 Created attachment 119116 [details]
Patch
Comment on attachment 119116 [details] Patch Attachment 119116 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10875046 New failing tests: fast/gradients/css3-radial-gradients.html fast/gradients/css3-repeating-radial-gradients.html Comment on attachment 119116 [details] Patch Attachment 119116 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10871059 Comment on attachment 119116 [details]
Patch
Looks good other than the failures. I can't see where radial gradient is failing.
GLSL uses the term "mix" where we use "blend" - I don't suppose it is worth the effort to change, and blend makes more sense.
(In reply to comment #4) > (From update of attachment 119116 [details]) > Attachment 119116 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10875046 > > New failing tests: > fast/gradients/css3-radial-gradients.html > fast/gradients/css3-repeating-radial-gradients.html Why don't these test failures show up in the output: http://queues.webkit.org/results/10875046 ? This patch broke Windows builds: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/36788/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/24728/steps/compile-webkit/logs/stdio lround isn't available on Visual Studio although it's part of ANSI C. (In reply to comment #9) > This patch broke Windows builds: > http://build.webkit.org/builders/Chromium%20Win%20Release/builds/36788/steps/compile-webkit/logs/stdio > http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/24728/steps/compile-webkit/logs/stdio > > lround isn't available on Visual Studio although it's part of ANSI C. Weird. lround was already being used - this patch just moved it. Seems that the build error was fixed by http://trac.webkit.org/changeset/102745 Ah, I was just about to make the same change. Thanks morrita! |