Bug 74462

Summary:

Add a very bare-bones implementation of bind and Function to WTF

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin+threading, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+, webkit.review.bot: commit-queue-

Description Anders Carlsson 2011-12-13 16:33:32 PST

Add a very bare-bones implementation of bind and Function to WTF

Comment 1 Anders Carlsson 2011-12-13 16:38:05 PST

Created attachment 119107 [details]
Patch

Comment 2 WebKit Review Bot 2011-12-13 16:39:25 PST

Attachment 119107 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/MainThread.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:131:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/Functional.h:145:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/MainThread.cpp:222:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/wtf/MainThread.cpp:227:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 8 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Review Bot 2011-12-13 17:12:27 PST

Comment on attachment 119107 [details]
Patch

Attachment 119107 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10872034

Comment 4 Sam Weinig 2011-12-13 17:17:05 PST

Comment on attachment 119107 [details]
Patch

Nice start!

Comment 5 Anders Carlsson 2011-12-13 18:59:21 PST

(In reply to comment #3)
> (From update of attachment 119107 [details])
> Attachment 119107 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10872034

I fixed this, turns out I put the Functional.cpp test in the wrong directory!

Comment 6 Anders Carlsson 2011-12-13 19:12:24 PST

Committed r102730: <http://trac.webkit.org/changeset/102730>