Summary: | Media url with fragment may not load | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Eric Carlson
2011-12-13 13:15:51 PST
Created attachment 119084 [details]
Proposed patch.
Attachment 119084 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1
Source/WebCore/platform/graphics/MediaPlayer.h:211: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 119084 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=119084&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:341 > + if (protocolIs(urlString, "data")) Would be better to call url.protocolIsData() since we have the URL. > Source/WebCore/platform/graphics/MediaPlayer.cpp:347 > - size_t pos = url.reverseFind('.'); > + String lastPathComponent = url.lastPathComponent(); > + size_t pos = lastPathComponent.reverseFind('.'); > if (pos != notFound) { > - String extension = url.substring(pos + 1); > + String extension = lastPathComponent.substring(pos + 1); Is this the only place in our code where we get the extension from a URL? If not, maybe they can share more code. > Source/WebCore/platform/graphics/MediaPlayer.h:37 > +#include "KURL.h" This include is not needed. All the header needs is a forward declaration of the KURL class. >> Source/WebCore/platform/graphics/MediaPlayer.h:211 >> - bool load(const String& url, const ContentType&); >> + bool load(const KURL& url, const ContentType&); > > The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] I agree with the style bot. |