Bug 74430

Summary: watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gns, jamesr, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Description Raphael Kubo da Costa (:rakuco) 2011-12-13 11:42:28 PST
watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-12-13 11:45:00 PST
Created attachment 119055 [details]
Patch
Comment 2 David Levin 2011-12-13 11:51:56 PST
Comment on attachment 119055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:123
> +            "more": r"CMakeLists.*\.txt"

Did you mean more here? That would mean that a file contains more references to this regex than it did before.

> Tools/Scripts/webkitpy/common/config/watchlist:154
> +        "EFLWebKitPublicAPI": [ "kubo@profusion.mobi" ],

I would add a comma after your email in each of these. (It isn't required but it makes it less error prone when someone adds the next entry so they don't accidentally merge together.)


You could also do "EFLWebKitPublicAPI|EFLWebCore|EFLTools|CMake|SoupNetwork": [ "kubo@profusion.mobi", ], if you wished. In some ways it depends on if you think others will add themselves to some of these sections.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-12-13 12:49:14 PST
(In reply to comment #2)
> (From update of attachment 119055 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review
> 
> > Tools/Scripts/webkitpy/common/config/watchlist:123
> > +            "more": r"CMakeLists.*\.txt"
> 
> Did you mean more here? That would mean that a file contains more references to this regex than it did before.

Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong.

> > Tools/Scripts/webkitpy/common/config/watchlist:154
> > +        "EFLWebKitPublicAPI": [ "kubo@profusion.mobi" ],
> 
> I would add a comma after your email in each of these. (It isn't required but it makes it less error prone when someone adds the next entry so they don't accidentally merge together.)

Oops, I overlooked that.

> You could also do "EFLWebKitPublicAPI|EFLWebCore|EFLTools|CMake|SoupNetwork": [ "kubo@profusion.mobi", ], if you wished. In some ways it depends on if you think others will add themselves to some of these sections.

Well, I'm thinking of joining all the EFL rules into a single one.
Comment 4 David Levin 2011-12-13 12:53:06 PST
Comment on attachment 119055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review

>>> Tools/Scripts/webkitpy/common/config/watchlist:123
>>> +            "more": r"CMakeLists.*\.txt"
>> 
>> Did you mean more here? That would mean that a file contains more references to this regex than it did before.
> 
> Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong.

Sorry. I welcome any hints about clarifications or if you could explain what you thought it said, I can try to reword it.

The more/less support is for matching within files. (For example, I use it to alert me about new uses of threading structures.)
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-12-13 12:58:56 PST
Created attachment 119071 [details]
Patch
Comment 6 David Levin 2011-12-13 13:01:04 PST
PS It is good to wait for the stylebot to finish its run on these patches to watchlist because it will catch any really bad mistakes.
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-12-13 13:03:45 PST
(In reply to comment #4)
> (From update of attachment 119055 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review
> 
> >>> Tools/Scripts/webkitpy/common/config/watchlist:123
> >>> +            "more": r"CMakeLists.*\.txt"
> >> 
> >> Did you mean more here? That would mean that a file contains more references to this regex than it did before.
> > 
> > Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong.
> 
> Sorry. I welcome any hints about clarifications or if you could explain what you thought it said, I can try to reword it.

The specific paragraphs which got me confused are these:

> If is a code pattern use “more” or “less”, if you want to know if more or less of instances in that pattern occur. (more use the regex to find a match modified lines in a patch. Then it searches the to see if more instances of that exact text occur on a per file basis.)

It looks like there are words missing after the first "If" and after "Then it searches the to see".

> A definition is said to match if all of its clauses are true for any file in a patch. If you could look for more instances of a pattern occurring only within a group of a files by using both “filename” and “more” together.

If you could look == you could look?
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-12-13 13:51:24 PST
Committed r102704: <http://trac.webkit.org/changeset/102704>