Bug 74429
| Summary: | [V8] WebCoreStringResource in V8Binding.cpp has both String and AtomicString | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Erik Arvidsson <arv> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | japhet, ojan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Erik Arvidsson
WebCoreStringResource in V8Binding.cpp has both a String and an AtomicString member. It should be enough to only have a String member since the string implementation of that can still be atomic.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Erik Arvidsson
There is a comment saying "Keeps the string buffer alive until the V8 engine garbage collects it." which means we cannot reassign it. Therefore the optimization I had in mind will not work.