Bug 74411

Summary: [Qt][GTK] The html5lib/runner.html test is start to fail after r102626
Product: WebKit Reporter: Oliver Varga <voliver>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, eric, gustavo, hausmann, kenneth, mrobinson, ossy, pnormand, webkit-sed, xan.lopez
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74343    
Bug Blocks:    
Attachments:
Description Flags
The diff file inconnection the fail. none

Attachments
The diff file inconnection the fail. (23.80 KB, text/plain)
2011-12-13 07:20 PST, Oliver Varga 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Oliver Varga
Comment 1 2011-12-13 07:20:24 PST
Created attachment 119017 [details] The diff file inconnection the fail.
Csaba Osztrogonác
Comment 2 2011-12-13 07:21:06 PST
It isn't Qt specific bug, because it fails on the GTK bot too.
Csaba Osztrogonác
Comment 3 2011-12-13 07:27:41 PST
It seems html5lib/resources/plain-text-unsafe.dat update killed the HTML5 parser on GTK and on Qt. Have you got any idea why?
Csaba Osztrogonác
Comment 4 2011-12-13 07:38:23 PST
*** Bug 74410 has been marked as a duplicate of this bug. ***
Adam Barth
Comment 5 2011-12-13 09:22:16 PST
What do you mean by killed? If qt and gtk keep their own baselines for this test, they probably need to be updated.
Csaba Osztrogonác
Comment 6 2011-12-13 09:26:34 PST
(In reply to comment #5) > What do you mean by killed? If qt and gtk keep their own baselines for this test, they probably need to be updated. I mean that test stopped during html5lib/resources/plain-text-unsafe.dat on Qt and GTK and don't run the following tests at all. (Qt and GTK don't have own baselines for this test case.)
Adam Barth
Comment 7 2011-12-13 12:29:42 PST
> I mean that test stopped during html5lib/resources/plain-text-unsafe.dat on Qt and GTK and don't run the following tests at all. Strange. Perhaps we should disable that data set.
Eric Seidel (no email)
Comment 8 2011-12-13 13:04:51 PST
Would be good to know why this is happening. :) Is it triggering the XML parser? Qt at least has a differnet xml parser from the rest of the project.
Csaba Osztrogonác
Comment 9 2011-12-13 22:50:31 PST
I skipped it on Qt, because bot must be green: http://trac.webkit.org/changeset/102742
Adam Barth
Comment 10 2011-12-22 00:00:41 PST
I've sharded the test. Hopefully that should make it run under the time limit. Should we remove it from the skipped lists to see?
Csaba Osztrogonác
Comment 11 2011-12-22 04:45:36 PST
(In reply to comment #10) > I've sharded the test. Hopefully that should make it run under the time limit. Should we remove it from the skipped lists to see? Thanks. I checked and all tests pass on Qt, so I unskipped it: http://trac.webkit.org/changeset/103527
Philippe Normand
Comment 12 2011-12-22 05:03:07 PST
Also unskipped in GTK via r103531. Thanks Adam!
Adam Barth
Comment 13 2011-12-22 09:26:10 PST
Yay!
Note You need to log in before you can comment on or make changes to this bug.