Bug 74406

Summary: [Qt][WK2] Move webView.page into experimental
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebKit QtAssignee: Rafael Brandao <rafael.lobo>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74403    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jesus Sanchez-Palencia
Reported 2011-12-13 06:14:50 PST
We are not sure if accessing webView.page will ever be an useful API, therefore we should move it into experimental and leave it cooking for a while. :)
Attachments
Patch (7.84 KB, patch)
2011-12-13 11:31 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Patch (3.80 KB, patch)
2011-12-15 09:56 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Patch (3.91 KB, patch)
2011-12-15 10:12 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2011-12-13 11:31:20 PST
Created attachment 119051 [details] Patch
Rafael Brandao
Comment 2 2011-12-13 11:33:13 PST
(In reply to comment #1) > Created an attachment (id=119051) [details] > Patch I had to change the tests and some other usages of page, but this is very straight forward. I've run the tests to make sure I didn't break anything. ;-)
Alexis Menard (darktears)
Comment 3 2011-12-13 13:02:13 PST
Comment on attachment 119051 [details] Patch LGTM
Simon Hausmann
Comment 4 2011-12-15 07:03:36 PST
Comment on attachment 119051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119051&action=review > Source/WebKit2/UIProcess/qt/QtPageClient.cpp:60 > - m_webView->page()->update(); > + m_webView->experimental()->page()->update(); It's ugly that we ourselves in our implementation have to use experimental API :) How about this: Keep the page() accessor in QQuickWebView, but remove the Q_PROPERTY (makes it disappear from QML). Instead add the Q_PROPERTY to to QQuickWebViewExperimental with a forwarding accessor.
Rafael Brandao
Comment 5 2011-12-15 09:56:19 PST
Created attachment 119446 [details] Patch
Rafael Brandao
Comment 6 2011-12-15 10:12:42 PST
Created attachment 119452 [details] Patch
WebKit Review Bot
Comment 7 2011-12-16 12:41:24 PST
Comment on attachment 119452 [details] Patch Clearing flags on attachment: 119452 Committed r103093: <http://trac.webkit.org/changeset/103093>
WebKit Review Bot
Comment 8 2011-12-16 12:41:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.