Bug 74404

Summary:

[Qt][WK2] Move WebPreferences into experimental

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebKit Qt

Assignee:

Rafael Brandao <rafael.lobo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, zoltan

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

74403

Attachments:

Description	Flags
Patch	none
Patch	none

Jesus Sanchez-Palencia

Reported 2011-12-13 06:05:36 PST

We need to move webView.preferences into the experimental set of APIs.

Attachments
Patch (8.38 KB, patch) 2011-12-13 12:18 PST, Rafael Brandao	no flags	Details Formatted Diff Diff
Patch (8.59 KB, patch) 2011-12-15 08:17 PST, Rafael Brandao	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rafael Brandao

Comment 1 2011-12-13 12:18:08 PST

Created attachment 119062 [details] Patch

Alexis Menard (darktears)

Comment 2 2011-12-13 13:03:00 PST

Comment on attachment 119062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119062&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:13 > + experimental.preferences.pluginsEnabled: true A bit annoying but we can leave with that for now.

WebKit Review Bot

Comment 3 2011-12-14 08:54:33 PST

Comment on attachment 119062 [details] Patch Rejecting attachment 119062 [details] from commit-queue. New failing tests: media/event-attributes.html Full output: http://queues.webkit.org/results/10875317

Caio Marcelo de Oliveira Filho

Comment 4 2011-12-14 10:19:57 PST

Comment on attachment 119062 [details] Patch Re-trying since error is unrelated to the patch.

WebKit Review Bot

Comment 5 2011-12-14 12:07:48 PST

Comment on attachment 119062 [details] Patch Rejecting attachment 119062 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /webkit-commit-queue/Source/WebKit/chromium/tools/gyp --revision 1104 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 43>At revision 1104. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10873335

Rafael Brandao

Comment 6 2011-12-15 08:17:25 PST

Created attachment 119428 [details] Patch

WebKit Review Bot

Comment 7 2011-12-15 09:22:12 PST

Comment on attachment 119428 [details] Patch Clearing flags on attachment: 119428 Committed r102948: <http://trac.webkit.org/changeset/102948>

WebKit Review Bot

Comment 8 2011-12-15 09:22:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.