Bug 74387
Summary: | WebKit2 fails to clean-build at r102658 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | WebKit Misc. | Assignee: | Michael Saboff <msaboff> |
Status: | RESOLVED FIXED | ||
Severity: | Blocker | CC: | andersca, ap, mhahnenberg, mrowe, msaboff, simon.fraser |
Priority: | P1 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Ryosuke Niwa
It appears that WebKit2 fails to build at r102658:
The following build commands failed:
ERROR: WebKit2 has a weak external symbol in it (/Users/rniwa/webkit2/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol bool WTF::equal<unsigned char, unsigned char>(unsigned char const*, unsigned char const*, unsigned int)
ERROR: symbol bool WTF::equal<unsigned short, unsigned short>(unsigned short const*, unsigned short const*, unsigned int)
Command /bin/sh failed with exit code 1
Command /bin/sh failed with exit code 1
WebKit2:
PhaseScriptExecution "Check For Weak VTables and Externals" /Users/rniwa/webkit2/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Script-5DF408C5131DD46700130071.sh
(1 failure)
Not sure why the failure isn't reproducing on the bots
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
It appears that this problem is to do with http://trac.webkit.org/changeset/102631.
Ryosuke Niwa
To give you more context, I'm on Snow Leopard with gcc version 4.2.1 (Apple Inc. build 5666) (dot 3).
Ryosuke Niwa
I've confirmed that WebKit build at r102630.
Michael Saboff
I changed the templates to overloaded functions in https://bugs.webkit.org/show_bug.cgi?id=74421. Could you try change set r102692: <http://trac.webkit.org/changeset/102692> and see if there is still a problem?
Ryosuke Niwa
(In reply to comment #4)
> I changed the templates to overloaded functions in https://bugs.webkit.org/show_bug.cgi?id=74421. Could you try change set r102692: <http://trac.webkit.org/changeset/102692> and see if there is still a problem?
Okay, will do.
Ryosuke Niwa
WebKit builds fine after the change.