Bug 74368

Summary:

Implement CSS font-size property in CSSStyleApplyProperty.

Product:

WebKit

Reporter:

Luke Macpherson <macpherson>

Component:

CSS

Assignee:

Luke Macpherson <macpherson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jchaffraix, kling, macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Luke Macpherson

Reported 2011-12-12 16:28:22 PST

Implement CSS font-size property in CSSStyleApplyProperty.

Attachments
Patch (13.98 KB, patch) 2011-12-12 16:31 PST, Luke Macpherson	no flags	Details Formatted Diff Diff
Patch for landing (13.91 KB, patch) 2011-12-18 16:44 PST, Luke Macpherson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Luke Macpherson

Comment 1 2011-12-12 16:31:33 PST

Created attachment 118902 [details] Patch

Andreas Kling

Comment 2 2011-12-18 15:41:38 PST

Comment on attachment 118902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118902&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:603 > + fontDescription.setKeywordSize(0); This should be removed as it's overwritten just below. > Source/WebCore/css/CSSStyleApplyProperty.cpp:608 > + if (size < 0) > + return; We should check this before copying the FontDescription to avoid unnecessary work. > Source/WebCore/css/CSSStyleApplyProperty.cpp:618 > + fontDescription.setKeywordSize(0); This should be removed as it's overwritten just below. > Source/WebCore/css/CSSStyleApplyProperty.cpp:623 > + if (size < 0) > + return; We should check this before copying the FontDescription to avoid unnecessary work. > Source/WebCore/css/CSSStyleApplyProperty.cpp:680 > + if (CSSPrimitiveValue::isUnitTypeLength(type)) if (primitiveValue->isLength()) > Source/WebCore/css/CSSStyleApplyProperty.cpp:682 > + else if (type == CSSPrimitiveValue::CSS_PERCENTAGE) else if (primitiveValue->isPercentage())

Luke Macpherson

Comment 3 2011-12-18 16:23:59 PST

Comment on attachment 118902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118902&action=review >> Source/WebCore/css/CSSStyleApplyProperty.cpp:603 >> + fontDescription.setKeywordSize(0); > > This should be removed as it's overwritten just below. Done. >> Source/WebCore/css/CSSStyleApplyProperty.cpp:608 >> + return; > > We should check this before copying the FontDescription to avoid unnecessary work. Done. >> Source/WebCore/css/CSSStyleApplyProperty.cpp:618 >> + fontDescription.setKeywordSize(0); > > This should be removed as it's overwritten just below. Done. >> Source/WebCore/css/CSSStyleApplyProperty.cpp:623 >> + return; > > We should check this before copying the FontDescription to avoid unnecessary work. fontDescription is used to calculate size in this case, so I've only moved fontDescription.setKeywordSize after this return. >> Source/WebCore/css/CSSStyleApplyProperty.cpp:680 >> + if (CSSPrimitiveValue::isUnitTypeLength(type)) > > if (primitiveValue->isLength()) Done. >> Source/WebCore/css/CSSStyleApplyProperty.cpp:682 >> + else if (type == CSSPrimitiveValue::CSS_PERCENTAGE) > > else if (primitiveValue->isPercentage()) Done.

Luke Macpherson

Comment 4 2011-12-18 16:44:46 PST

Created attachment 119788 [details] Patch for landing

WebKit Review Bot

Comment 5 2011-12-18 19:01:48 PST

Comment on attachment 119788 [details] Patch for landing Clearing flags on attachment: 119788 Committed r103208: <http://trac.webkit.org/changeset/103208>

WebKit Review Bot

Comment 6 2011-12-18 19:01:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.