Bug 74355

Summary:

Remove vptrs from JSCell hierarchy

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

74353

Bug Blocks:

74331

Attachments:

Description	Flags
Remove vptrs from JSCell hierarchy	ggaren: review+
Remove cruft added during sequence	ggaren: review+
Remove VPtrStealingHack, more JIT fixes	ggaren: review+
Get 32-bit building	ggaren: review+
Getting Windows building	ggaren: review+

Mark Hahnenberg

Reported 2011-12-12 15:11:40 PST

Now that we've de-virtualized all of the destructors, we can remove any bogus virtual vtableAnchor() functions we left behind to keep things working along with all of the remaining vptr optimizations in the JIT and the garbage collector. This patch ended up a little bigger than I intended because I was having trouble getting tests to pass, so I ended up trying a lot of stuff I had planned for later in an attempt to get things working.

Attachments
Remove vptrs from JSCell hierarchy (104.82 KB, patch) 2011-12-12 15:12 PST, Mark Hahnenberg	ggaren: review+	Details Formatted Diff Diff
Remove cruft added during sequence (31.04 KB, patch) 2011-12-12 15:14 PST, Mark Hahnenberg	ggaren: review+	Details Formatted Diff Diff
Remove VPtrStealingHack, more JIT fixes (22.17 KB, patch) 2011-12-12 15:16 PST, Mark Hahnenberg	ggaren: review+	Details Formatted Diff Diff
Get 32-bit building (8.80 KB, patch) 2011-12-12 15:17 PST, Mark Hahnenberg	ggaren: review+	Details Formatted Diff Diff
Getting Windows building (5.21 KB, patch) 2011-12-12 15:17 PST, Mark Hahnenberg	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2011-12-12 15:12:39 PST

Created attachment 118872 [details] Remove vptrs from JSCell hierarchy No changelog (see bug 74331).

Mark Hahnenberg

Comment 2 2011-12-12 15:14:30 PST

Created attachment 118875 [details] Remove cruft added during sequence Remove a lot of the compiler cruft used to get things to build earlier on. Also fixed up the 32-bit JIT a bit, although at this point it still wouldn't have built if I had tested it :-/

Mark Hahnenberg

Comment 3 2011-12-12 15:16:07 PST

Created attachment 118876 [details] Remove VPtrStealingHack, more JIT fixes Again, a little schizophrenic of a patch. Removed VPtrStealingHack related code, made some JIT fixes.

Mark Hahnenberg

Comment 4 2011-12-12 15:17:18 PST

Created attachment 118878 [details] Get 32-bit building Getting 32 bit JIT stuff building.

Mark Hahnenberg

Comment 5 2011-12-12 15:17:51 PST

Created attachment 118879 [details] Getting Windows building Getting Windows building.

Geoffrey Garen

Comment 6 2011-12-12 15:35:55 PST

Comment on attachment 118872 [details] Remove vptrs from JSCell hierarchy r=me

Geoffrey Garen

Comment 7 2011-12-12 15:38:00 PST

Comment on attachment 118875 [details] Remove cruft added during sequence r=me

Geoffrey Garen

Comment 8 2011-12-12 15:38:23 PST

Comment on attachment 118876 [details] Remove VPtrStealingHack, more JIT fixes r=me

Geoffrey Garen

Comment 9 2011-12-12 15:38:44 PST

Comment on attachment 118878 [details] Get 32-bit building r=me

Geoffrey Garen

Comment 10 2011-12-12 15:39:16 PST

Comment on attachment 118879 [details] Getting Windows building r=me

Note You need to log in before you can comment on or make changes to this bug.