| Summary: | WebAudio: Enable USE_CONCATENATED_IMPULSE_RESPONSES on Mac port. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | crogers, eric.carlson, pnormand | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2011-12-12 14:00:16 PST
Created attachment 118839 [details]
Patch
Created attachment 118895 [details]
Patch
Rebased patch against ToT.
Nice, I'm happy to see Mac willing to use this code! Comment on attachment 118895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118895&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:20636 > + CD4AC5251496AB2C0087C4EF /* SincResampler.h */, I could be wrong, but I thought that I had already added the SincResampler files to the Xcode project - you might want to double-check (In reply to comment #4) > (From update of attachment 118895 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118895&action=review > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:20636 > > + CD4AC5251496AB2C0087C4EF /* SincResampler.h */, > > I could be wrong, but I thought that I had already added the SincResampler files to the Xcode project - you might want to double-check Looks like that's true. I'll excerpt that part of project.pbxproj. Created attachment 122304 [details]
Patch
Removed the (unnecessary) additions of SincResampler.h/cpp in the project.pbxproj file.
Committed r104859: <http://trac.webkit.org/changeset/104859> |