| Summary: | Don't crash in StyleAttributeMutationScope if the style declaration's element has been GCed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||||||
| Component: | New Bugs | Assignee: | Adam Klein <adamk> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | macpherson, ojan, rafaelw, rniwa, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Klein
2011-12-12 12:47:25 PST
Created attachment 118827 [details]
Patch
Created attachment 118846 [details]
Added crbug to ChangeLog
Comment on attachment 118846 [details] Added crbug to ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=118846&action=review > Source/WebCore/ChangeLog:8 > + Initially reported as http://crbug.com/107231. You should describe how the crash was caused and how you fixed. The link to crbug.com usually belongs in Bugzilla, not in the changelog. Initially reported as http://crbug.com/107231 Created attachment 118853 [details]
Add ChangeLog details
Comment on attachment 118853 [details] Add ChangeLog details View in context: https://bugs.webkit.org/attachment.cgi?id=118853&action=review > Source/WebCore/ChangeLog:18 > + In r101101, Rafael Weinstein added code to CSSMutableStyleDeclaration.cpp > + which depended on isInlineStyleDeclaration returning true iff the > + element it pointed to was non-null (it will be nulled-out if the > + element is garbage collected). > + > + Then, in r101172, Andreas Kling changed the semantics so that > + isInlineStyleDeclaration only described the type of the declaration, > + not the state of the related element. > + > + This change updates Rafael's code with an explicit check that the > + element is still alive. Great! Thanks for adding this description. It makes a huge difference when we're going to look at svn blame in the future. Comment on attachment 118853 [details] Add ChangeLog details Clearing flags on attachment: 118853 Committed r102639: <http://trac.webkit.org/changeset/102639> All reviewed patches have been landed. Closing bug. |