Bug 74318

Summary: Removing BlackBerryCookieCache from the build system
Product: WebKit Reporter: ocheung
Component: PlatformAssignee: ocheung
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

ocheung
Reported 2011-12-12 12:26:21 PST
Removing any references to BlackBerryCookieCache from upstreamed BlackBerry platform files, as well as removing the file from the build system in CMakeListsBlackBerry.txt in WebCore,
Attachments
Patch (2.91 KB, patch)
2011-12-14 14:01 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2011-12-14 14:11 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Patch (2.92 KB, patch)
2011-12-14 14:28 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2011-12-15 06:37 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2011-12-15 06:41 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2011-12-15 07:33 PST, ocheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
ocheung
Comment 1 2011-12-14 14:01:17 PST
Created attachment 119292 [details] Patch
Antonio Gomes
Comment 2 2011-12-14 14:06:09 PST
Comment on attachment 119292 [details] Patch lets fix the changelog entry, otto :)
ocheung
Comment 3 2011-12-14 14:11:11 PST
Created attachment 119293 [details] Patch
ocheung
Comment 4 2011-12-14 14:13:17 PST
commit-queue:?
ocheung
Comment 5 2011-12-14 14:28:32 PST
Created attachment 119298 [details] Patch
Antonio Gomes
Comment 6 2011-12-14 14:38:57 PST
hope the patch applies.
WebKit Review Bot
Comment 7 2011-12-14 17:28:26 PST
Comment on attachment 119298 [details] Patch Rejecting attachment 119298 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ile(s). patching file Source/WebCore/CMakeListsBlackBerry.txt Hunk #1 FAILED at 134. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/CMakeListsBlackBerry.txt.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/network/blackberry/NetworkJob.cpp Hunk #2 succeeded at 304 (offset -4 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/10903023
ocheung
Comment 8 2011-12-15 06:37:55 PST
Created attachment 119419 [details] Patch
ocheung
Comment 9 2011-12-15 06:41:10 PST
Created attachment 119420 [details] Patch
Rob Buis
Comment 10 2011-12-15 07:13:26 PST
Comment on attachment 119420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119420&action=review Reviewd By line is wrong, r- for now, rest is fine. > Source/WebCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). Should be moved up, see other commits.
ocheung
Comment 11 2011-12-15 07:33:18 PST
Created attachment 119426 [details] Patch
Rob Buis
Comment 12 2011-12-15 07:37:48 PST
Comment on attachment 119426 [details] Patch LGTM.
WebKit Review Bot
Comment 13 2011-12-15 07:54:03 PST
Comment on attachment 119426 [details] Patch Clearing flags on attachment: 119426 Committed r102937: <http://trac.webkit.org/changeset/102937>
WebKit Review Bot
Comment 14 2011-12-15 07:54:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.