Bug 74269 – Implement a cache for CSSStyleRule::selectorText()

• Component: CSS
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

Patch to follow.

[Alexander Pavlov (apavlov)]

Created attachment 118754 [details]
Patch

[Alexander Pavlov (apavlov)]

Created attachment 118782 [details]
[PATCH] ChangeLog entry augmented

[Andreas Kling]

Comment on attachment 118782 [details]
[PATCH] ChangeLog entry augmented

View in context: https://bugs.webkit.org/attachment.cgi?id=118782&action=review

r=me, but please inline cleanup() before landing.

> Source/WebCore/css/CSSStyleRule.cpp:51
> +    cleanup();

I'd rather we inline cleanup() here to avoid introducing a perf regression (however tiny) in document teardown.

> Source/WebCore/css/CSSStyleRule.cpp:126
> +    if (m_hasCachedSelectorText) {
> +        ASSERT(selectorTextCache().contains(this));
> +        selectorTextCache().remove(this);
> +        m_hasCachedSelectorText = false;
> +    }
> +
>      if (this->selectorText() == oldSelectorText)
>          return;

We could factor this differently to reduce hash map churn (the remove() is always followed by a set().)

[Alexander Pavlov (apavlov)]

Committed r102584: <http://trac.webkit.org/changeset/102584>