Bug 74263

Summary: WebPImageDecoder: Increase image/webp decoding performance 10-20%
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: noel.gordon, pascal.massimino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 58851    
Attachments:
Description Flags
Patch none

noel gordon
Reported 2011-12-11 20:29:08 PST
Data copies from RGB m_rgbBuffer to the pixel backing store, via buffer.setRGBA(), are costly.
Attachments
Patch (7.59 KB, patch)
2011-12-11 20:31 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2011-12-11 20:31:45 PST
Created attachment 118725 [details] Patch
WebKit Review Bot
Comment 2 2011-12-12 00:10:52 PST
Comment on attachment 118725 [details] Patch Clearing flags on attachment: 118725 Committed r102561: <http://trac.webkit.org/changeset/102561>
WebKit Review Bot
Comment 3 2011-12-12 00:10:56 PST
All reviewed patches have been landed. Closing bug.
Pascal Massimino
Comment 4 2011-12-12 03:18:53 PST
lgtm. Thanks for doing this! This means: every incoming features (alpha, etc.) will have to be thought-out mainly from the incremental perspective.
noel gordon
Comment 5 2011-12-13 22:15:19 PST
s/mainly/eventually/, if alpha images did not initially support progressive decodes, I'd use "allDataReceived" in the code. Of course early in decoding setup, where grab the image size say, is where I'd want to find out if the image has alpha.
Note You need to log in before you can comment on or make changes to this bug.