Bug 74248

Summary: Remove OS(SYMBIAN) block from Settings constructor.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Description Andreas Kling 2011-12-10 16:38:32 PST
SSIA
Comment 1 Andreas Kling 2011-12-10 16:40:51 PST
Created attachment 118699 [details]
Patch
Comment 2 Benjamin Poulain 2011-12-10 18:54:45 PST
Comment on attachment 118699 [details]
Patch

I am ok with this particular change but do you know why we have passwordEchoEnabled at all? Maybe we can remove that setting entierly?
Comment 3 Benjamin Poulain 2011-12-10 19:06:31 PST
Ok, that was added in 93656.

This code comes from iOS, so it makes sense to keep it.
Comment 4 Andreas Kling 2011-12-11 11:34:15 PST
Committed r102539: <http://trac.webkit.org/changeset/102539>