Bug 74238 – Unify inspectors preprocessor statements

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

[Patrick R. Gansterer]

Unify inspectors preprocessor statements

[Patrick R. Gansterer]

Created attachment 118692 [details]
Patch

[Pavel Feldman]

Comment on attachment 118692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118692&action=review

> Source/WebCore/inspector/ConsoleMessage.h:34
> +#if ENABLE(INSPECTOR)

Here and below: I don't think we should guard header private to inspector: including them from outside of inspector should break !ENABLE(INSPECTOR) configurations and hence point to the problem. I'd rather go through inspector internals and wipe out similar guards from headers there.

[Patrick R. Gansterer]

Comment on attachment 118692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118692&action=review

>> Source/WebCore/inspector/ConsoleMessage.h:34
>> +#if ENABLE(INSPECTOR)
> 
> Here and below: I don't think we should guard header private to inspector: including them from outside of inspector should break !ENABLE(INSPECTOR) configurations and hence point to the problem. I'd rather go through inspector internals and wipe out similar guards from headers there.

how can I classify them? is there a clear attribute for the public/private decision?

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 118692 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118692&action=review
> 
> >> Source/WebCore/inspector/ConsoleMessage.h:34
> >> +#if ENABLE(INSPECTOR)
> > 
> > Here and below: I don't think we should guard header private to inspector: including them from outside of inspector should break !ENABLE(INSPECTOR) configurations and hence point to the problem. I'd rather go through inspector internals and wipe out similar guards from headers there.
> 
> how can I classify them? is there a clear attribute for the public/private decision?

1) WebCore should only communicate with the inspector by means of InspectorInstrumentation interface. This interface is designed so that the call site would not have to wrap the calls to it with ENABLED(INSPECTOR).

2) WebKit (and maybe one or two extra places in WebCore) communicate with the inspector by means of the InspectorController interface. All these usages should be hidden behind the ifdefs.

Rest of the headers is considered to be private to the inspector.

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.