Bug 74226

Summary: [chromium] Always use border texels on platforms using pageScaleDelta
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, enne, jamesr, sievers, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexandre Elias
Reported 2011-12-09 16:40:38 PST
[chromium] Always use border texels on platforms using pageScaleDelta
Attachments
Patch (2.09 KB, patch)
2011-12-09 16:43 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2011-12-09 16:43:35 PST
Created attachment 118665 [details] Patch
Alexandre Elias
Comment 2 2011-12-09 16:44:56 PST
cc'ing wjmaclean@ as you'll likely run into the same problem.
James Robinson
Comment 3 2011-12-09 17:08:46 PST
Comment on attachment 118665 [details] Patch R=me
Alexandre Elias
Comment 4 2011-12-09 17:56:54 PST
cq- as it causes compositing/checkerboard.html layout test to fail. I'll see if I can set GL_NEAREST conditionally on whether there's a transform.
WebKit Review Bot
Comment 5 2011-12-09 18:18:32 PST
Comment on attachment 118665 [details] Patch Rejecting attachment 118665 [details] from commit-queue. aelias@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Alexandre Elias
Comment 6 2011-12-09 18:20:33 PST
OK, the GL_NEAREST fix is proving more trouble than it's worth (the data isn't easily available from CCTiledLayerImpl::drawTiles(), and GL_NEAREST in the presence of border texels causes other tests to fail for some reason), so I guess we can submit this and I'll disable the checkerboard layout test downstream.
WebKit Review Bot
Comment 7 2011-12-21 20:56:54 PST
Comment on attachment 118665 [details] Patch Clearing flags on attachment: 118665 Committed r103490: <http://trac.webkit.org/changeset/103490>
WebKit Review Bot
Comment 8 2011-12-21 20:56:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.