Bug 74225

Summary: chromium win build: revert build_webkit_exes_from_webkit_gyp change
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
fix mac target as well none

Description Dirk Pranke 2011-12-09 16:01:08 PST 
chromium win build: revert build_webkit_exes_from_webkit_gyp change
Comment 1 Dirk Pranke 2011-12-09 16:02:07 PST 
Created attachment 118661 [details]
Patch
Comment 2 Tony Chang 2011-12-09 16:04:19 PST 
Comment on attachment 118661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118661&action=review

> Tools/Scripts/webkitdirs.pm:2084
>          $result = buildXCodeProject("Source/WebKit/chromium/All", $clean, "-configuration", configuration(), @options);

What about mac? Doesn't it also need to build WebKit instead of All?
Comment 3 Dirk Pranke 2011-12-09 16:06:57 PST 
Created attachment 118662 [details]
fix mac target as well
Comment 4 Dirk Pranke 2011-12-09 16:07:12 PST 
good catch. please take another look?
Comment 5 Dirk Pranke 2011-12-09 16:41:49 PST 
Comment on attachment 118662 [details]
fix mac target as well

Clearing flags on attachment: 118662

Committed r102490: <http://trac.webkit.org/changeset/102490>
Comment 6 Dirk Pranke 2011-12-09 16:41:52 PST 
All reviewed patches have been landed.  Closing bug.