Summary: | [GStreamer] webkitwebsrc: pad template is leaked | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Judy Liqiong Hao <judy.liqiong-hao> | ||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, pnormand, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Judy Liqiong Hao
2011-12-09 15:49:21 PST
Created attachment 118663 [details]
proposed patch
Thanks for spotting this! The pad template is still leaked in the case where appsrc is not created though? Can you use GRefPtr for this GstPadTemplate pointer? You'd need to add support for it in GRefPtrGStreamer. Comment on attachment 118663 [details] proposed patch r- as per above remarks, some of which I applied in the patch of bug 74495 Ping Judy? (In reply to comment #4) > Ping Judy? Yes? (In reply to comment #5) > (In reply to comment #4) > > Ping Judy? > > Yes? Do you mind updating this patch? (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Ping Judy? > > > > Yes? > Do you mind updating this patch? Will send out a new patch for review ... Created attachment 121685 [details]
Patch
Comment on attachment 121685 [details] Patch Clearing flags on attachment: 121685 Committed r104475: <http://trac.webkit.org/changeset/104475> All reviewed patches have been landed. Closing bug. |