Bug 74209

Summary:

WK2/NetscapePlugin: Incorrect mouse event coordinates when frameScaleFactor != 1.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Plug-ins

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch v2	none

Description Andreas Kling 2011-12-09 13:24:36 PST

<rdar://10438197>

Comment 1 Andreas Kling 2011-12-09 13:36:33 PST

Created attachment 118625 [details]
Patch

Comment 2 Anders Carlsson 2011-12-09 13:39:20 PST

Comment on attachment 118625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118625&action=review

I think you should be able to write a plug-in test for this. Maybe platform/mac/plugins/convert-point.html could be extended to also run the same tests when there's a scale factor applied.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:-709
> -    // FIXME: Just passing a translation matrix isn't good enough.

I think you can keep this comment, but change it to say that we don't get the right coordinates for transformed plug-ins.

Comment 3 Andreas Kling 2011-12-10 16:31:01 PST

Created attachment 118698 [details]
Patch v2

Same patch with the FIXME tweaked and a layout test.

Comment 4 Andreas Kling 2011-12-11 11:39:19 PST

Comment on attachment 118698 [details]
Patch v2

Clearing flags on attachment: 118698

Committed r102540: <http://trac.webkit.org/changeset/102540>

Comment 5 Andreas Kling 2011-12-11 11:39:39 PST

All reviewed patches have been landed.  Closing bug.