Summary: | Web Inspector: [Chromium] add support to inspector test suite to fetch test execution results from console | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, keishi, loislo, pfeldman, pmuellr, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-12-09 13:20:28 PST
Created attachment 118622 [details]
Patch
Comment on attachment 118622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review > Source/WebKit/chromium/src/js/Tests.js:561 > +TestSuite.prototype.testWaitForResultsInConsole = function() Could you elaborate on how you intend to use this? Comment on attachment 118622 [details]
Patch
Clearing the r? while waiting for the clarification to remote it from the dashboard.
(In reply to comment #3) > (From update of attachment 118622 [details]) > Clearing the r? while waiting for the clarification to remote it from the dashboard. See http://codereview.chromium.org/8899008/ for context. Basically, we use console as a poor man's IPC here: the test actually runs asynchronously in another context and reports the results to the inspector console. Comment on attachment 118622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review >> Source/WebKit/chromium/src/js/Tests.js:561 >> +TestSuite.prototype.testWaitForResultsInConsole = function() > > Could you elaborate on how you intend to use this? Could you pick a more specific name for the test method? > Source/WebKit/chromium/src/js/Tests.js:568 > + else if (/^FAIL/.test(text)) If there are several failures you may want to print all of them. (In reply to comment #5) > (From update of attachment 118622 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118622&action=review > > >> Source/WebKit/chromium/src/js/Tests.js:561 > >> +TestSuite.prototype.testWaitForResultsInConsole = function() > > > > Could you elaborate on how you intend to use this? > > Could you pick a more specific name for the test method? Sounds like this is not a method, but rather is a part of the harness. It would be great to get a bigger picture in the ChangeLog... > > > Source/WebKit/chromium/src/js/Tests.js:568 > > + else if (/^FAIL/.test(text)) > > If there are several failures you may want to print all of them. renamed to TestSuite.prototype.waitForTestResultsInConsole, added a ChangeLog with a reference to usage. Committed r102928: <http://trac.webkit.org/changeset/102928> |