Bug 74205 – IndexedDB: Clean up WebIDBObjectStore createIndex temp code

• Component: WebKit API
• Status: RESOLVED FIXED

[Joshua Bell]

Now that callers (i.e. Chromium) are updated to implement the new signatures, the old methods can be removed:

diff --git a/Source/WebKit/chromium/public/WebIDBObjectStore.h b/Source/WebKit/chromium/public/WebIDBObjectStore.h
index 4448a9b..ab3df5f 100755
--- a/Source/WebKit/chromium/public/WebIDBObjectStore.h
+++ b/Source/WebKit/chromium/public/WebIDBObjectStore.h
@@ -70,16 +70,7 @@ public:
     virtual void put(const WebSerializedScriptValue&, const WebIDBKey&, PutMode, WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
     virtual void deleteFunction(const WebIDBKey&, WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
     virtual void clear(WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
-    // FIXME: Remove once callers are updated.
-    virtual WebIDBIndex* createIndex(const WebString& name, const WebString& keyPath, bool unique, const WebIDBTransaction& transaction, WebExceptionCode& ec)
-    {
-        return createIndex(name, keyPath, unique, false, transaction, ec);
-    }
-    virtual WebIDBIndex* createIndex(const WebString& name, const WebString& keyPath, bool unique, bool multiEntry, const WebIDBTransaction& transaction, WebExceptionCode& ec)
-    {
-        // FIXME: Assert not reached once implementing classes are updated.
-        return createIndex(name, keyPath, unique, transaction, ec);
-    }
+    virtual WebIDBIndex* createIndex(const WebString& name, const WebString& keyPath, bool unique, bool multiEntry, const WebIDBTransaction& transaction, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); }
     // Transfers ownership of the WebIDBIndex to the caller.
     virtual WebIDBIndex* index(const WebString& name, WebExceptionCode&)
     {

[Joshua Bell]

Created attachment 119500 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[WebKit Review Bot]

Comment on attachment 119500 [details]
Patch

Clearing flags on attachment: 119500

Committed r103025: <http://trac.webkit.org/changeset/103025>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.