Bug 74189

Summary: WebKit should ignore images with @alt matching only whitespace
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Description chris fleizach 2011-12-09 10:57:25 PST 
WebKit should ignore images with @alt matching only whitespace

These are caused by <img alt=" "> (whitespace string); I think those should be treated the same way as alt="" (empty string). Ignore them completely.
Comment 1 chris fleizach 2011-12-09 10:57:53 PST 
rdar://10550385
Comment 2 chris fleizach 2011-12-09 11:01:42 PST 
Created attachment 118595 [details]
patch
Comment 3 Darin Adler 2011-12-09 11:41:14 PST 
Comment on attachment 118595 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118595&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1900
> +            if (!alt.string().stripWhiteSpace().isEmpty())

A better way to write this is:

    if (!alt.string().containsOnlyWhitespace())

One subtle issue is that the containsOnlyWhitespace function uses the isASCIISpace definition of whitespace, not the HTML space definition, and there are some almost certainly irrelevant subtle differences between the two.
Comment 4 chris fleizach 2011-12-09 13:26:02 PST 
http://trac.webkit.org/changeset/102470