Bug 74175

Summary:

[Refactoring] In prepare-ChangeLog, move top-level code to generate change-log lists into a method

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

Tools / Tests

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, ddkilzer, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

73531

Attachments:

Description	Flags
Patch	none
rebased patch for commit	none

Description Kentaro Hara 2011-12-09 02:54:04 PST

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing. This requires to remove top-level code. This is one of the incremental refactorings for that.

Comment 1 Kentaro Hara 2011-12-09 03:07:07 PST

Created attachment 118555 [details]
Patch

Comment 2 Kentaro Hara 2011-12-09 03:10:37 PST

rniwa: Thanks. I'll stop refactoring today, since further refactoring requires all previous patches to be landed.

Comment 3 David Kilzer (:ddkilzer) 2011-12-09 16:53:34 PST

(In reply to comment #1)
> Created an attachment (id=118555) [details]
> Patch

This looks like a great first step.  Thanks!

Comment 4 Ryosuke Niwa 2011-12-09 16:54:32 PST

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=118555) [details] [details]
> > Patch
> 
> This looks like a great first step.  Thanks!

Indeed! haraken++

Comment 5 Kentaro Hara 2011-12-10 03:09:32 PST

Created attachment 118688 [details]
rebased patch for commit

Comment 6 Kentaro Hara 2011-12-10 03:12:28 PST

rniwa: Oops, I forgot to add the --no-review --no-obsolete option for uploading the rebased patch. Would you r+ again please?

Comment 7 WebKit Review Bot 2011-12-10 22:32:21 PST

Comment on attachment 118688 [details]
rebased patch for commit

Clearing flags on attachment: 118688

Committed r102536: <http://trac.webkit.org/changeset/102536>

Comment 8 WebKit Review Bot 2011-12-10 22:32:25 PST

All reviewed patches have been landed.  Closing bug.